Ryan Palm

I love yofiel and synthcore for all the cool things that he shared there. But one thing I don't get, is how all the codebox examples he shared, or many of them dont work with a simple copy paste, as I think they are intended to do. 

I'd just like to add an output to this envelope, but the ways I've tried with my limited understanding return errors when sent out of the gen patcher to max.

I love yofiel and synthcore for all the cool things that he shared there.  But one thing I don't get, is how all the codebox examples he shared, or many of them dont work with a simple copy paste, as I think they are intended to do. 

I'd just like to add an output to this envelope, but the ways I've tried with my limited understanding return errors when sent out of the gen patcher to max.

I love yofiel and synthcore for all the cool things that he shared there.  But one thing I don't get, is how all the codebox examples he sha

how-to-add-an-output-to-this-envelope-code-synthcore

So this is the code. At the end adding a "out1 = env" doesnt seem to work. And a few other ways I've tried. Just a bit what these all were intended for as they don't seem to be able to be connected to anything and are written in a way that doesnt resemble codebox work I've seen elsewhere.

adsr(gate,predelay,att,dec,sus,susn,rel){ 						// BASIC ADSR
// gate: 		+ve transitions from prior value start gate
// predelay: 	sample clock / sample cycles for 5 ms delay 
// att: 		sample clock / sample cycles for attack
// dec: 		sample clock / sample cycles for dec
// sus: 		sustain between 0 & 1
// susn:		1 - sustain
// rel:			sample clock / sample cycles for release
// returns env level 0~1
	Buffer pow25("pow25");
	History hinc, henv, hlvl;
	inc = hinc;
	trg = change(gate);
	out1 = env;
		if (trg >0) {		// envelope on
		if (henv) {			//if trg and env already on, add 5ms decay
			inc = 1;
			hlvl = henv;
		} else inc = 2;	
	} else if (trg <0) {	// envelope off
		inc = 5;
		hlvl = henv;
	}
	inc += selector(hinc,	// set inc for each phase duration
		predelay,			// 1: pre-decay time
		att,				// 2: attack time
		dec,   				// 3: decay time
		0, 					// 4: hold on sustain
		rel,  				// 5: release time
		0);					// 6: end of env cycle
	env = selector(floor(inc),								// calc output levels
		sample (pow25, 1 - wrap(inc, 0, 1)) * hlvl,			// 1. pre-decay
		sample (pow25, wrap(inc, 0, 1)),					// 2. attack
		sample (pow25, 1 - wrap(inc, 0, 1)) * susn + sus,	// 3. decay
		sus,												// 4. sustain
		sample (pow25, 1 - wrap(inc, 0,1)) * hlvl,			// 5. release
		0);													// 6. end of cycle
	hinc = inc;
	henv = env;
	return env;
}

adsr here is a function declaration, there is no instanciation of the function, and the variable "env" doesn't exist outside of the scope of that function ; you need to instantiate it inside the same codebox where you have that declaration - alternately you may save that code in a .genexpr file, put that file in your max search path and write in a gen~ codebox the following line : "require yofieladsr" (if you saved that genexpr as yofieladsr.genexpr for example.)

Instantiating inside codebox (with the function declaration inside the same codebox, so not the "require" method here) would look something like :

where you have 7 input to the codebox, 1 for each argument required to call the function (gate, predel, atk, sus, rls etc)

adsr(gate,predelay,att,dec,sus,susn,rel){ 	
      [...]
      }
      
out1 = adsr(in1, in2, in3, in4, in5, in5, in7);

Yofiel's synthcore is definitely intended to be used as a library, though. So you have the synthcore.genexpr file which contains all the function declarations, and which you need to put in a folder available to your Max search paths. Then if you look at the _LIBRARY_DEMO.maxpat, you can check for each example how he uses "require synthcore;" at the beginning of each codebox inside gen~ ; then he can call any function available in that library. Example for using the adsr, you'd just need to write this inside a codebox inside a gen~ subpatcher :

out1 = adsr(in1, in2, in3, in4, in5, in5, in7);

Yofiel's synthcore is definitely intended to be used as a library, though. So you have the synthcore.genexpr file which contains all the function declarations, and which you need to put in a folder available to your Max search paths.  Then if you look at the _LIBRARY_DEMO.maxpat, you can check for each example how he uses "require synthcore;" at the beginning of each codebox inside gen~ ; then he can call any function available in that library. Example  for using the adsr, you'd just need to write this inside a codebox inside a gen~ subpatcher :
 
require synthcore;
out1 = adsr(in1, in2, in3, in4, in5, in5, in7);


Hi, I think I forgot to mention that envelopes also require some preloaded data into buffers to calulate curves, which it does to reduce CPU usage. That is the Buffer pow25, which is in the demo patch. You can also load different data into the buffer if you want a different curve. What I should have said is, any of the methods with buffers in them are going to need similar preloaded data as in the demo patch. Apologies.

Thanks for all the help and advice guys. And Ernest! You know, I am actually the person who contacted you several months ago when Synthcore was still dormant. Super happy you released an updated version for everyone. I am active with the Daisy dsp microprocessor for making gen~ synths come to life in hardware. And using this package has brought both me and some others Ive spoken too a lot of joy. So thanks for that.

Also, I am using this topics discussion to make hopefully one of the most usable digital eurorack kicks. I figured I'd share my recent version which lives and is explained here: 

https://www.spacepupsound.com/copy-of-daisy-patch

of course, envelope's are key getting a good electronic kick :)

Also, I am using this topics discussion to make hopefully one of the most usable digital eurorack kicks. I figured I'd share my recent version which lives and is explained here: https://www.spacepupsound.com/copy-of-daisy-patch 

How to add an output to this envelope code (synthcore)?