sefable2 sefable2

Using node 4 max, calling "process.exit(1)" does not work.

I am using winston logging and this is how this library handles exceptions and errors while still insuring logging messages are flushed on disk.

Hello,
Using node 4 max, calling "process.exit(1)" does not work.
Is there any way to make it work?
I am using winston logging and this is h

node-4-max-process-exit-1-does-not-work

can you be a bit more specific? I've just tested with a simple script that calls 

 upon receiving a bang and it worked as expected:

const Max = require("max-api");

Max.addHandler("bang", () => {
    process.exit(0);
});

So I wonder what "does not work" means in your case?

can you be a bit more specific? I've just tested with a simple script that calls process.exit() upon receiving a bang and it worked as expected:

const Max = require("max-api");

Max.addHandler("bang", () => {
	process.exit(0);
});

I think this has to do with the fact that I'm calling process.exit(0); outside of a Max Handler.

I'm calling it, in your example, between "const Max .." and "Max.addHandler"

When I call it, the code continues to run the next javascript statements instead of stopping there.

Ok. It's not related to the Max Handler. Looking at the code it's due to the fact that the 

in order to for it to allow as expected in conjunction with 

Generally the process exiting happens as expected, however the way the process is torn down is somewhat 

 partly in order to distinguish wanted / expected shutdowns from caught errors, and can therefore lead to additional code execution before the process exits. I assume eventually 

 operates as expected in your case but u see some additional execution until the process is fully closed.

I agree that's not ideal and should act more spec / API compliant in a future version of N4M.

Ok. It's not related to the Max Handler. Looking at the code it's due to the fact that the N4M Shell (also known as NSRunner) has a custom implementation of process.exit in order to for it to allow as expected in conjunction with node.script and therefore Max.

Generally the process exiting happens as expected, however the way the process is torn down is somewhat async, partly in order to distinguish wanted / expected shutdowns from caught errors, and can therefore lead to additional code execution before the process exits. I assume eventually process.exit operates as expected in your case but u see some additional execution until the process is fully closed.

Thanks for getting to the bottom of this.

I can implement what I need and node 4 max is a great addition.

But my error management and logging as a result is quite subpar.

Thanks for getting to the bottom of this. 

I can implement what I need and node 4 max is a great addition. 

But my error management and logging as a result is quite subpar. 

node 4 max - process.exit(1) does not work