synthcore library taken offline; simplified ADSR envelope in gen~

People had problems passing values into my ADSR function, so I simplified it, attached. Also, I removed the function call, as apparently user functions are also too complicated for anyone who has sent me patches trying to use it.

This attached patch is a functional improvement on the 7-stage gen~ example in that the release phase works properly. It still assumes the gate has been turned off for at least one audio cycle before it is turned on, which I need to mention as it has been a problem for students. Also, if the envelope is playing sound and you restart it, there will be a click when the envelope suddenly reduces gain to zero, for which a release phase at the beginning can be added that stops the click. Not everyone needs that,, and it adds a delay to the start of the note (typically 5 msec) that sequencer writers find particularly objectionable. So I left it for you to add your own declicking code if you need it. That way you can decide for yourself whether to subtract the prerelease from the attack phase, delay other notes by 5msec, or just add it when necessary. Or you may prefer to modify it so the envelope starts at its previously level instead of resetting to the beginning of the attack phase. At least that provides an "educational resource" that is appropriately meaningful.

With regards to the other 130 functions in my library, so far over a dozen instructors thanked me for the "educational resource," but otherwise, the only times I know of that people have used it since RNBO was released was when students sent me patches saying it didn't work. In all cases, it was something they did not me.

So I had to conclude, people teaching C74 have just made students despise me, as function libraries are not intended as "educational resources" in the first place. They are intended for people who want to make apps with efficient code. No one that I know of wants it for that, so I took the library offline. Now no one has a reason to despise me anymore. Have a nice day )