Synth Building Blocks Package - Sustain Issue

Jelani Thompson's icon

Hey everyone.

Just working on adding a sustain pedal functionality to my project, but running into an issue with the sustain module that the synth building blocks package includes.

The module successfully sustains the held note, but when it toggles off, it doesn't send the note-off message. Does anyone here know what the issue might be? Tried my own approach, and it sends a 0 message to velocity at the right time, but the note continues to play. Not sure what the issue might be here.

Thanks in advance,

Jelani

Isabel Kaspriskie's icon

Hi Jelani,

I believe the issue is that the [gate 2] is sending a list to [pack i 1] and pack isn't understanding that. If I put an unpack there, get out the midi note number, then pack it into a list that [bag] understands (the note number to add to the "pending" note off bag -- done by sending bag a list of [pitch, non-zero value]), then it's okay. I also would change the bag attribute @duplicate to on, to allow multiple note-offs to be sent for a single pitch.

I'll get a fix into the package soon. :)

Jelani Thompson's icon

Thank you! 🙏🏾